-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Old Dev UI: Arc #34971
Removed Old Dev UI: Arc #34971
Conversation
This comment has been minimized.
This comment has been minimized.
Seems like this needs to be the last extension being removed. I'll keep it draft for now, until I can rebase on a branch where all other extensions has been cleaned |
2b3f27d
to
5ffbc72
Compare
This comment has been minimized.
This comment has been minimized.
CI is not happy :) |
Yeah this one needs more work |
👌🏼 |
5ffbc72
to
6cf84cf
Compare
This comment has been minimized.
This comment has been minimized.
I'm a bit worried about the CI failures. |
@cescoffier I know what is going on, will fix soon |
Shouldn't we add a replacement of the |
@mkouba the tests is already copied to new set of tests. For Arc see https://github.com/quarkusio/quarkus/blob/main/integration-tests/devmode/src/test/java/io/quarkus/test/devui/DevUIArcJsonRPCTest.java and https://github.com/quarkusio/quarkus/blob/main/integration-tests/devmode/src/test/java/io/quarkus/test/devui/DevUIArcBuildTimeDataTest.java I'll fix this PR soon. I need to remove some other things in vertx-http before I can finalize this PR |
6cf84cf
to
a16397a
Compare
This comment has been minimized.
This comment has been minimized.
a16397a
to
4f8235a
Compare
This comment has been minimized.
This comment has been minimized.
4f8235a
to
7b464ab
Compare
This comment has been minimized.
This comment has been minimized.
7b464ab
to
6b1f794
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6b1f794
to
9c1a2ca
Compare
Signed-off-by: Phillip Kruger <[email protected]>
9c1a2ca
to
c12a875
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building c12a875
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Security2 #- Failing: integration-tests/oidc
📦 integration-tests/oidc✖
|
Removing the old Dev UI from Arc extension