Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Old Dev UI: Arc #34971

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

phillip-kruger
Copy link
Member

Removing the old Dev UI from Arc extension

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/vertx labels Jul 25, 2023
@phillip-kruger phillip-kruger mentioned this pull request Jul 25, 2023
42 tasks
@quarkus-bot

This comment has been minimized.

@phillip-kruger phillip-kruger marked this pull request as draft July 25, 2023 01:59
@phillip-kruger
Copy link
Member Author

Seems like this needs to be the last extension being removed. I'll keep it draft for now, until I can rebase on a branch where all other extensions has been cleaned

@phillip-kruger phillip-kruger marked this pull request as ready for review July 27, 2023 02:44
@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 27, 2023
@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Jul 27, 2023

CI is not happy :)

@phillip-kruger
Copy link
Member Author

Yeah this one needs more work

@geoand
Copy link
Contributor

geoand commented Jul 27, 2023

👌🏼

@quarkus-bot

This comment has been minimized.

@cescoffier
Copy link
Member

I'm a bit worried about the CI failures.

@phillip-kruger
Copy link
Member Author

@cescoffier I know what is going on, will fix soon

@mkouba
Copy link
Contributor

mkouba commented Aug 1, 2023

Shouldn't we add a replacement of the DevConsoleArcSmokeTest for the new dev UI? Or we do we have some other tests somewhere else?

@phillip-kruger
Copy link
Member Author

@mkouba the tests is already copied to new set of tests. For Arc see https://github.com/quarkusio/quarkus/blob/main/integration-tests/devmode/src/test/java/io/quarkus/test/devui/DevUIArcJsonRPCTest.java and https://github.com/quarkusio/quarkus/blob/main/integration-tests/devmode/src/test/java/io/quarkus/test/devui/DevUIArcBuildTimeDataTest.java

I'll fix this PR soon. I need to remove some other things in vertx-http before I can finalize this PR

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot quarkus-bot bot added area/kafka-streams area/persistence OBSOLETE, DO NOT USE area/qute The template engine labels Aug 11, 2023
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

Signed-off-by: Phillip Kruger <[email protected]>
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 15, 2023

Failing Jobs - Building c12a875

Status Name Step Failures Logs Raw logs
Native Tests - Security2 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Security2 #

- Failing: integration-tests/oidc 

📦 integration-tests/oidc

io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testSecureAccessSuccessWithCors - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <404>.

@phillip-kruger phillip-kruger merged commit feb5f4d into quarkusio:main Aug 16, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 16, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 16, 2023
@phillip-kruger phillip-kruger deleted the dev-ui-remove-arc branch August 16, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/kafka-streams area/persistence OBSOLETE, DO NOT USE area/qute The template engine area/reactive-sql-clients area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants